-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added plot preset #4427
Added plot preset #4427
Conversation
data/presets/presets/place/plot.json
Outdated
"place": "plot" | ||
}, | ||
"terms": [ | ||
"plot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't actually need to include the word "plot" as a search term - it will be included automatically because it is the tag value.
Instead, add synonyms here like ["tract", "parcel", "lot"]
Thanks so much for your contribution! The |
Thanks for letting me know. I have updated the search terms array, so hopefully now it should contain synonyms as requested. |
Thanks for your contribution @humanforklift , looks great 👍 |
I don't think that adding a preset for By adding the preset to the "official" editor (it is embedded into the official web page of the project) people could have the impression that it is permitted [1] to map them. In addition, the presets asks for a name tag. What will the name of mapped parcels be? I fear that it will be the name of the owner. I abstain from writing down more arguments against this tag because this bug tracker is not the tagging mailing list. Therefore, I would like to ask all who are involved to reconsider their decision. A technical comment: Why is the diff of this pull request so large? The pull request aims to add a single tagging preset but changes lots of other files. Is this necessary? [1] I know the "you can tag what you want roule" |
There are 28k of them already mapped and it has an osm wiki page. It's an established tag, so that's why we added a preset. I try to avoid make decisions about whether something "belongs" in OSM or not. If people want it mapped and they are using legal sources, that is good enough for me.
Presets like "Building" and "House" support a name field too. It's also discouraged to put people's real names there, but nobody is calling to remove the building presets just because a few mappers might make that mistake. I do think adding rules to OSMCha like "Name added to Building" or "Name added to Plot" would be a good way to surface issues like this to local reviewers. I don't actually know how the tag is used, but if
Feel free to discuss on the mailing list.. I'll see it, but I usually don't participate unless somebody tries to suggest a tag scheme that is technically difficult for us to support. If the OSM community decides to remove all of these from the database and wiki, I'll happily remove the preset too.
The user who submitted the pull request is a new contributor (thank you!!), and rebuild the generated presets file using outdated name-suggestion and editor-imagery dependencies. This is a minor issue, so I just rebuilt them myself (2bb7b5a) using updated dependencies. |
Apologies if I caused any confusion - definitely still getting the hang of this. How can I avoid using outdated name-suggestion and editor-imagery dependencies in the future? |
I think running |
I have added a new presets JSON file for place=plot.
I'm new to this, so let me know if I need to change anything.